Use dependency injection for runner #10326
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larryliu0820
requested review from
jackzhxng,
iseeyuan,
swolchok,
kirklandsign,
lucylq and
shoumikhin
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10326
Note: Links to docs will display an error until the docs builds have been completed. ❌ 14 New FailuresAs of commit c4bf4be with merge base b71f03c ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73165546 |
This PR needs a
|
facebook-github-bot
pushed a commit
to pytorch-labs/tokenizers
that referenced
this pull request
Apr 21, 2025
Summary: X-link: pytorch/executorch#10326 Pass in runner components, move most of the instantiation logic from `load()` to a new static API `create()`. This adds testability to runner components. Differential Revision: D73165546
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 21, 2025
Summary: X-link: pytorch-labs/tokenizers#53 Pass in runner components, move most of the instantiation logic from `load()` to a new static API `create()`. This adds testability to runner components. Differential Revision: D73165546
facebook-github-bot
force-pushed
the
export-D73165546
branch
from
1fe0afa to
16e3256
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73165546 |
lucylq
reviewed
Apr 22, 2025
| @@ -30,18 +30,22 @@ namespace example { | |||
|
|
|||
| class ET_EXPERIMENTAL Runner : public executorch::extension::llm::IRunner { | |||
| public: | |||
| explicit Runner( | |||
| // Static factory method to create a Runner instance | |||
| static std::unique_ptr<Runner> create( | |||
There was a problem hiding this comment.
Will most users interact with runner via this API?
swolchok
reviewed
Apr 22, 2025
There was a problem hiding this comment.
I am generally opposed to both tests that use mocks and dependency injection.
I am generally opposed to mocks because they tend to produce change detector tests. For the case at hand, why not create a Runner and see if it decodes the right number of tokens?
I am generally opposed to dependency injection because pass-from-above is typically all you need in order to accomplish the usual stated goals. In this particular diff, I don't immediately understand what Runner::create is accomplishing; I don't see any sort of flag that causes it to return a different Runner in a test environment, nor do the tests use it.
swolchok
reviewed
Apr 22, 2025
| } // namespace | ||
|
|
||
| Runner::Runner( | ||
| std::unique_ptr<Runner> Runner::create( |
There was a problem hiding this comment.
Specifically, it looks like create() could just be another Runner constructor; it's not clear to me why it has to be a static method instead.
swolchok
reviewed
Apr 22, 2025
|
|
||
| [[deprecated( | ||
| "This constructor is deprecated. Use the constructor without temperature parameter instead.")]] | ||
| // Constructor with dependency injection | ||
| explicit Runner( |
There was a problem hiding this comment.
looks like I was confused in my original comment. This form of dependency injection (pass from above) is fine; I thought Runner::create was going to be part of a trend of giving everything a create method and therefore building our own dependency injection framework.
Summary: Pull Request resolved: #10338 The ownership of these components need some clarification. * `Module` should be shared by `TextDecoderRunner` and potentially `TextPrefiller` (or `ImagePrefiller` in multimodal runner). * `TextDecoderRunner` should be shared by the `TextPrefiller` and `TextTokenGenerator`. * `Tokenizer` should be owned by the `Runner` as well as `TextTokenGenerator`. Differential Revision: D73399600 Reviewed By: kirklandsign
larryliu0820
added a commit
to pytorch-labs/tokenizers
that referenced
this pull request
Apr 22, 2025
Summary: X-link: pytorch/executorch#10326 Pass in runner components, move most of the instantiation logic from `load()` to a new static API `create()`. This adds testability to runner components. Differential Revision: D73165546
larryliu0820
added a commit
that referenced
this pull request
Apr 22, 2025
Summary: X-link: pytorch-labs/tokenizers#53 Pass in runner components, move most of the instantiation logic from `load()` to a new static API `create()`. This adds testability to runner components. Differential Revision: D73165546
larryliu0820
force-pushed
the
export-D73165546
branch
from
16e3256 to
91c0f0a
Compare
Summary: Pull Request resolved: #10326 X-link: pytorch-labs/tokenizers#53 Pass in runner components, move most of the instantiation logic from `load()` to a new static API `create()`. This adds testability to runner components. Differential Revision: D73165546
|
This pull request was exported from Phabricator. Differential Revision: D73165546 |
larryliu0820
force-pushed
the
export-D73165546
branch
from
91c0f0a to
c4bf4be
Compare
larryliu0820
added a commit
to pytorch-labs/tokenizers
that referenced
this pull request
Apr 22, 2025
Summary: X-link: pytorch/executorch#10326 Pull Request resolved: #53 Pass in runner components, move most of the instantiation logic from `load()` to a new static API `create()`. This adds testability to runner components. Differential Revision: D73165546
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Pass in runner components, move most of the instantiation logic from
load()to a new static APIcreate().This adds testability to runner components.
Differential Revision: D73165546